Update palette #1215
Update palette #1215
Conversation
Generated by 🚫 dangerJS |
javamonn
force-pushed
the
try-updating-palette
branch
from
1f279dd
to
7b64981
Compare
javamonn
force-pushed
the
try-updating-palette
branch
from
7b64981
to
23b26fa
Compare
| @@ -76,14 +76,14 @@ class Artwork extends React.Component<Props, any> { | |||
| <Badges> | |||
| {is_acquireable && ( | |||
| <Badge> | |||
| <Sans fontSize={8} lineHeight={8} style={{ paddingTop: 1 }} weight="medium" size="1"> | |||
| <Sans fontSize="8px" lineHeight={8} style={{ paddingTop: 1 }} weight="medium" size="1"> | |||
There was a problem hiding this comment.
Without the px hardcoding here, the values appearing in the snapshot changed dramatically from 8 to something like 72. I think this was the result of the issue described in artsy/reaction#1535.
There was a problem hiding this comment.
Hmm, interesting... is it only affecting the snapshot or is the line height also affected in the UI?
There was a problem hiding this comment.
I think this is related to @mzikherman updating the badges to include an item that was outside of Palette's theme file, per @briansw's request.
There was a problem hiding this comment.
It affects both:
Before fixing px:
After:
My understanding of the issue is that it only affects spots where we're passing values into fontSize and lineHeight overrides like this, though this makes me concerned about us potentially doing this in spots we don't cover with snapshot tests - I'll see if I can find any other affected spots with a search.
Edit: this appears to be the only spot we do this kind of override in Emission.
There was a problem hiding this comment.
@javamonn - would you mind raising this in #front-end so that others don't get tripped up accidentally?
| @@ -31,7 +31,7 @@ const durationSections = (duration: Duration, labels: [string, string, string, s | |||
| ] | |||
|
|
|||
| const LabeledTimeSection: React.SFC<TimeSectionProps> = ({ time, label, timeTextProps, labelTextProps }) => ( | |||
| <Flex alignItems="center" justifyConent="center"> | |||
| <Flex alignItems="center" justifyContent="center"> | |||
There was a problem hiding this comment.
One advantage of upgrading: this was not caught as a type error before 👏
javamonn
force-pushed
the
try-updating-palette
branch
from
b9802af
to
dd6060d
Compare
| @@ -17,6 +17,7 @@ | |||
| ### Master | |||
|
|
|||
| - Refactor auctions countdown timer, add fair countdown timer - javamonn | |||
| - Updates @artsy/palette (2.21.1) - javamonn | |||
There was a problem hiding this comment.
Right on 👍 Thanks for bringing that PR over the line.
There was a problem hiding this comment.
🙌
You're awesome @javamonn
javamonn
force-pushed
the
try-updating-palette
branch
from
dd6060d
to
7f74fbd
Compare
|
merge on green |
javamonn
force-pushed
the
try-updating-palette
branch
from
7f74fbd
to
8b64195
Compare
Updates palette to latest version.
See https://github.com/artsy/palette/pull/109/files for the associated PR on palette.
#trivial
#skip_new_tests